Fix: Caching of rendered dbt model configs by making the dependencies attribute public#768
Merged
izeigerman merged 1 commit intomainfrom Apr 26, 2023
Merged
Conversation
… attribute public
izeigerman
commented
Apr 26, 2023
tobymao
approved these changes
Apr 26, 2023
crericha
reviewed
Apr 26, 2023
| if "macros" not in exclude: | ||
| out["macros"] = [macro.dict() for macro in self.macros] | ||
|
|
||
| return out |
Contributor
There was a problem hiding this comment.
We already have an attribute_dict method. Can that be used?
Contributor
Author
There was a problem hiding this comment.
attribute_dict relies on Pydantic dict() and fails without this change. This method overrides the Pydantic's dict().
Contributor
There was a problem hiding this comment.
Okay, I didn't realize it was an override.
crericha
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.