Feat: Add ability to set the effective date for forward-only snapshots#785
Merged
izeigerman merged 3 commits intomainfrom Apr 28, 2023
Merged
Feat: Add ability to set the effective date for forward-only snapshots#785izeigerman merged 3 commits intomainfrom
izeigerman merged 3 commits intomainfrom
Conversation
eakmanrq
reviewed
Apr 28, 2023
tobymao
reviewed
Apr 28, 2023
| return self._effective_from | ||
|
|
||
| @effective_from.setter | ||
| def effective_from(self, effective_from: t.Optional[TimeLike]) -> None: |
Contributor
There was a problem hiding this comment.
why have this and both _set_effective_from? why not just have the setter?
Contributor
Author
There was a problem hiding this comment.
So that it doesn't look confusing when we set in the constructor.
Contributor
There was a problem hiding this comment.
i don't think it will be confusing?
if effective_from:
self.effective_from = effective_from is fine right?
Contributor
Author
There was a problem hiding this comment.
It'd be more like:
self._effective_from = None
if effective_from:
self.effective_from = effective_from is fine right?
So it looks like we're setting it twice, which is a confusing part.
Contributor
There was a problem hiding this comment.
you don't need to initialize the first one
Contributor
Author
There was a problem hiding this comment.
I do, because plan.effective_from will return an attribute error if I never set it.
tobymao
reviewed
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.