Fix: When applying a forward-only plan in dev the backfill should precede the promotion#786
Merged
izeigerman merged 1 commit intomainfrom Apr 28, 2023
Merged
Conversation
…ecede the promotion
vchan
approved these changes
Apr 28, 2023
Contributor
vchan
left a comment
vchan
left a comment
There was a problem hiding this comment.
So always backfill before promotion in dev?
Contributor
Author
|
@vchan that's correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot that it's ok to backfill before promoting when applying a forward-only plan in dev, since all forward-only snapshots target temp tables and no schema migration takes place.