Skip to content

Feat: Docs#801

Merged
mykalmax merged 11 commits intomainfrom
feat-docs
May 5, 2023
Merged

Feat: Docs#801
mykalmax merged 11 commits intomainfrom
feat-docs

Conversation

@mykalmax
Copy link
Contributor

@mykalmax mykalmax commented May 2, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 2, 2023

CLA assistant check
All committers have signed the CLA.

@mykalmax mykalmax force-pushed the feat-docs branch 2 times, most recently from 4ed7752 to 661a5c8 Compare May 5, 2023 14:44
@mykalmax mykalmax marked this pull request as ready for review May 5, 2023 20:31
Copy link
Contributor

@vchan vchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few typos and add back in the models endpoint test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const Documantation = function Documantation({
const Documentation = function Documentation({

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const indeces = useMemo(() => createIndeces(models), [models])
const indices = useMemo(() => createIndices(models), [models])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const indeces: Array<[Model, string]> = []
const indices: Array<[Model, string]> = []

@mykalmax mykalmax merged commit 37cffef into main May 5, 2023
@mykalmax mykalmax deleted the feat-docs branch May 5, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants