Feat: Gateway configuration BREAKING CHANGE#807
Merged
izeigerman merged 2 commits intomainfrom May 4, 2023
Merged
Conversation
…e gateways. BREAKING CHANGE
|
|
tobymao
reviewed
May 4, 2023
| self._scheduler = self.config.scheduler | ||
| self.connection = connection | ||
| self.test_connection = test_connection | ||
| self.gateway = gateway |
Contributor
There was a problem hiding this comment.
just so you're aware of the implications on line 219, and also with self.gateway, we're making t he assumption that multi repo works with one gateway
tobymao
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration entity: "gateway". Thanks to this new entity users are now able to configure different combinations of connection and scheduler configurations and easily switch between them in the CLI.
Additionally, this change decouples the connection used for model evaluation from the connection used to write and read the SQLMesh state. This means that users can now configure external databases to store SQLMesh state instead of using their data warehouse for this purpose.
Note: Support for external state connections for Airflow is out of this update's scope. It will be added in a follow-up PR.