Skip to content

Fix: Update sys_path before loading models. #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobymao merged 1 commit into from
May 26, 2023
Merged

Fix: Update sys_path before loading models. #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sqlmesh/core/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,10 @@ def refresh(self) -> None:
if self._loader.reload_needed():
self.load()

def load(self) -> Context:
def load(self, update_schemas: bool = True) -> Context:
"""Load all files in the context's path."""
with sys_path(*self.configs):
project = self._loader.load(self)
project = self._loader.load(self, update_schemas)
self._hooks = project.hooks
self._macros = project.macros
self._models = project.models
Expand Down Expand Up @@ -844,13 +844,15 @@ def create_external_models(self) -> None:
The schema file contains all columns and types of external models, allowing for more robust
lineage, validation, and optimizations.
"""
models = self._models or self._loader.load(self, update_schemas=False).models
if not self._models:
self.load(update_schemas=False)

for path, config in self.configs.items():
create_schema_file(
path=path / c.SCHEMA_YAML,
models={
name: model
for name, model in models.items()
for name, model in self._models.items()
if self.config_for_model(model) is config
},
adapter=self._engine_adapter,
Expand Down