This repository was archived by the owner on Sep 3, 2024. It is now read-only.
Update Build Scripts #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamralph
suggested changes
Oct 12, 2018
build/build.csproj
Outdated
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Bullseye" Version="1.2.0-rc.2" /> | ||
| <PackageReference Include="Bullseye" Version="1.2.0" /> |
build/build.csproj
Outdated
| <ItemGroup> | ||
| <PackageReference Include="Bullseye" Version="1.2.0-rc.2" /> | ||
| <PackageReference Include="Bullseye" Version="1.2.0" /> | ||
| <PackageReference Include="SimpleExec" Version="2.3.0" /> |
Contributor
There was a problem hiding this comment.
FWIW, this can be bumped to 3.0.0.
build.sh
Outdated
| docker build \ | ||
| --build-arg TRAVIS_OS_NAME=$TRAVIS_OS_NAME \ | ||
| --build-arg TRAVIS_BUILD_NUMBER=$TRAVIS_BUILD_NUMBER \ | ||
| --build-arg MYGET_API_KEY=$MYGET_API_KEY . |
Contributor
There was a problem hiding this comment.
One problem here is that arguments supplied to build.sh are not being passed through. That needs to happen if you want to pass any args to Bullseye, otherwise you're missing out on all this. build.cmd has the same problem.
Dockerfile
Outdated
| WORKDIR / | ||
|
|
||
| RUN TRAVIS_BUILD_NUMBER=$TRAVIS_BUILD_NUMBER MYGET_API_KEY=$MYGET_API_KEY dotnet run --project build/build.csproj | ||
| RUN TRAVIS_OS_NAME=$TRAVIS_OS_NAME TRAVIS_BUILD_NUMBER=$TRAVIS_BUILD_NUMBER MYGET_API_KEY=$MYGET_API_KEY dotnet run --project build/build.csproj |
Contributor
There was a problem hiding this comment.
Likewise, any remaining args need to be passed through to Bullseye here, otherwise you cannot pass any args to Bullseye from build.sh.
thefringeninja
force-pushed
the
chicago-bullseye
branch
2 times, most recently
from
f8aa1e7 to
691b8da
Compare
- Bullseye 2.2.0 - SimpleExec 3.0.0 - Replaced versioning nightmare wih minver
thefringeninja
force-pushed
the
chicago-bullseye
branch
from
05c7ca7 to
1daafe1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.