Conversation
(cherry picked from commit 9469559145fcf30235c5fd5d6da397db43b8b753)
Source upstream commit: c14c29c5588cb3a8685fe4f9e0b698322b93ea69 Source upstream commit: 461979c5b4207c1e1a27ecba80d7629b66bac45d Port scope: adapted
miccy
added
upstream
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves monorepo reliability by introducing a centralized TypeScript project-reference typecheck, updating several development dependencies, and aligning workspace package manifests/build configs with the new typecheck setup.
Changes:
- Added root
tsconfig.typecheck.jsonand atypecheckscript, and wired it intoverify. - Updated/added various package configs: dependency bumps, missing workspace
devDependencies, and new per-packagetsconfig.build.jsonfiles. - Added a web-platform
reloadApputility and clarified schema/query-builder documentation; minor E2E test refactor for readability.
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.typecheck.json |
New root project-references entrypoint for centralized typechecking across packages. |
package.json |
Adds typecheck script, runs it during verify, bumps Biome, and adds overrides. |
bun.lock |
Lockfile updates reflecting dependency bumps and overrides. |
biome.json |
Updates schema URL to match the bumped Biome version. |
packages/bun/tsconfig.build.json |
Adds build tsconfig for project references alignment. |
packages/svelte/tsconfig.build.json |
Adds build tsconfig with appropriate references/includes for Svelte package. |
packages/web/src/Platform.js |
Adds a web reloadApp implementation (runtime module). |
packages/web/src/Platform.d.ts |
Adds type declarations for the new Platform.js module. |
packages/web/src/Platform.d.ts.map |
Adds source map for the Platform.d.ts. |
packages/web/package.json |
Bumps @types/sharedworker. |
packages/astro/package.json |
Adds missing workspace devDependencies for local development/linking. |
packages/tanstack-start/package.json |
Adds missing workspace devDependencies for local development/linking. |
packages/tauri/package.json |
Adds missing workspace devDependencies for local development/linking. |
packages/common/src/local-first/Schema.ts |
Doc update re: Kysely relations-style composition; adds related imports. |
packages/common/test/local-first/Protocol.test.ts |
Refactors it(..., { timeout }) formatting for readability. |
examples/react-nextjs/package.json |
Bumps postcss. |
examples/angular-vite-pwa/package.json |
Bumps @analogjs/vite-plugin-angular. |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements across the monorepo, focusing on enhanced type checking, dependency updates, and improved package configuration. The most significant changes include the addition of a centralized TypeScript type checking process, updates to development dependencies for better compatibility and security, and the inclusion of missing workspace dependencies in several package manifests.
Type Checking and Build Process Improvements:
tsconfig.typecheck.jsonat the root to enable centralized type checking for all packages, and updated the mainpackage.jsonto include atypecheckscript and to run it as part of theverifyprocess. [1] [2] [3]Dependency and Package Configuration Updates:
@biomejs/biome,@analogjs/vite-plugin-angular,postcss, and@types/sharedworker. [1] [2] [3] [4] [5]@evolu/common,@evolu/react,@evolu/react-web) to thedevDependenciesof theastro,tanstack-start, andtauripackages to ensure proper linkage and development experience. [1] [2] [3]tsconfig.build.jsonfiles forbunandsvelteto align with the new type checking setup and improve build consistency. [1] [2]overridessection in the rootpackage.jsonto enforce a specific version ofserialize-javascriptfor security and consistency.Code and Documentation Enhancements:
reloadAppinpackages/web/src/Platform.jsfor reloading the app in a browser environment.evoluSchemaToSqliteSchemato clarify support for Kysely relation-style query composition.Protocol.test.tsto simplify timeout configuration and improve readability. [1] [2] [3]Summary by CodeRabbit
Chores
Tests