Skip to content

Conversation

@Deipher
Copy link
Contributor

@Deipher Deipher commented Oct 27, 2014

No description provided.

@SQiShER
Copy link
Owner

SQiShER commented Oct 27, 2014

Perfect! Thanks! I'll merge it later today.

@SQiShER
Copy link
Owner

SQiShER commented Oct 27, 2014

You don't happen to have written a little benchmark that I can add to the test suite in order to prevent regressions?

@SQiShER
Copy link
Owner

SQiShER commented Oct 27, 2014

Alright, it's merged. It will be released along with the refactoring/extension of the InclusionService which I'm currently working on. My changes may have an impact on your performance optimizations, as I'm planning to move the different inclusion mechanisms into separate strategies. I'll try to factor your optimizations into the rewrite as good as I can, but please let me know if you observe any decrease in performance.

Thanks again for your help!

@SQiShER SQiShER closed this Oct 27, 2014
@Deipher
Copy link
Contributor Author

Deipher commented Oct 28, 2014

Nice !
I also created a new pull request concerning the Collections.java classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.

2014-10-27 23:26 GMT+01:00 Daniel Bechler notifications@github.com:

Closed #113 #113.


Reply to this email directly or view it on GitHub
#113 (comment).

@Deipher
Copy link
Contributor Author

Deipher commented Oct 28, 2014

I will work on writing a benchmark for the previous changes
(InclusionService)

2014-10-28 9:03 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:

Nice !
I also created a new pull request concerning the Collections.java classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.

2014-10-27 23:26 GMT+01:00 Daniel Bechler notifications@github.com:

Closed #113 #113.


Reply to this email directly or view it on GitHub
#113 (comment).

@Deipher
Copy link
Contributor Author

Deipher commented Oct 28, 2014

I have written a benchmark but i'm using a library called "dummyCreator" to
inject randomly data in my objects.

de.dev-eth0.dummycreator
dummy-creator
1.2
test

How can i send you the test classes and java models ?

2014-10-28 9:04 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:

I will work on writing a benchmark for the previous changes
(InclusionService)

2014-10-28 9:03 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:

Nice !
I also created a new pull request concerning the Collections.java classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.

2014-10-27 23:26 GMT+01:00 Daniel Bechler notifications@github.com:

Closed #113 #113.


Reply to this email directly or view it on GitHub
#113 (comment).

@SQiShER
Copy link
Owner

SQiShER commented Oct 28, 2014

Cool! Can you just put it in a public Github repository? If you don't want to do that, maybe via Dropbox Link?

On 28.10.2014, at 13:49, Deipher notifications@github.com wrote:

I have written a benchmark but i'm using a library called "dummyCreator" to
inject randomly data in my objects.

de.dev-eth0.dummycreator
dummy-creator
1.2
test

How can i send you the test classes and java models ?

2014-10-28 9:04 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:

I will work on writing a benchmark for the previous changes
(InclusionService)

2014-10-28 9:03 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:

Nice !
I also created a new pull request concerning the Collections.java classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.

2014-10-27 23:26 GMT+01:00 Daniel Bechler notifications@github.com:

Closed #113 #113.


Reply to this email directly or view it on GitHub
#113 (comment).


Reply to this email directly or view it on GitHub.

@Deipher
Copy link
Contributor Author

Deipher commented Oct 28, 2014

I can't push anything from where i am (security of the company) so here is
the archive of the project.

2014-10-28 15:07 GMT+01:00 Daniel Bechler notifications@github.com:

Cool! Can you just put it in a public Github repository? If you don't want
to do that, maybe via Dropbox Link?

On 28.10.2014, at 13:49, Deipher notifications@github.com wrote:

I have written a benchmark but i'm using a library called "dummyCreator"
to
inject randomly data in my objects.

de.dev-eth0.dummycreator
dummy-creator
1.2
test

How can i send you the test classes and java models ?

2014-10-28 9:04 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:

I will work on writing a benchmark for the previous changes
(InclusionService)

2014-10-28 9:03 GMT+01:00 Frédéric Toublanc <
frederic.toublanc@oniryx.be>:

Nice !
I also created a new pull request concerning the Collections.java
classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.

2014-10-27 23:26 GMT+01:00 Daniel Bechler notifications@github.com:

Closed #113 #113.


Reply to this email directly or view it on GitHub
<
https://github.com/SQiShER/java-object-diff/pull/113#event-184380590>.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#113 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants