Fix stale bindings leaking between execute_many() parameter sets#554
Merged
Conversation
SRombauts
added a commit
that referenced
this pull request
Jun 29, 2026
|
coverage: 99.711%. first build — fix-executemany-clearbindings into master |
SRombauts
added a commit
that referenced
this pull request
Jun 30, 2026
SRombauts
added a commit
that referenced
this pull request
Jun 30, 2026
SRombauts
added a commit
that referenced
this pull request
Jun 30, 2026
reset_bind_exec() called reset() then re-bound the next tuple, but reset() leaves previous bindings in place. A parameter set that bound fewer values than the previous one silently reused the leftover values. Call clearBindings() after reset() so every set starts clean. Add a regression test exercising decreasing arity across parameter sets.
SRombauts
force-pushed
the
fix-executemany-clearbindings
branch
from
71e8b3f to
e656cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute_many() reset the statement between parameter sets but never cleared the bindings, so a set that bound fewer values than the previous one silently reused the leftover values (silent data corruption). Call clearBindings() after reset() so each parameter set starts clean.
Adds a regression test covering decreasing arity across parameter sets.