Skip to content

Conversation

@rafbianco
Copy link
Collaborator

No description provided.

rafbianco and others added 30 commits February 4, 2020 21:39
This will apply the sum rule convolving with a Gaussian in real space (or in Fourier).
 - less memory expensive
 - allows to set a maximum distance between atoms in the centering
1. In principle, space symmetries should be imposed at each iteration,
   like the permutation symmetry
2. Printed units must be verified (now the 3rdFC are written as eV/A**3)
Some improvements in the Spectral.py file
I modified just the GetQGrid.
@mesonepigreco
Copy link
Collaborator

Ok, I'm going to solve the conflict before the merge.
However, we should insert some numerical tests in order to spot immediately bugs if we insert them in future (for example when adding the effective charges).
@rafbianco do you have some simple case that can be used as a test?

@mesonepigreco
Copy link
Collaborator

I created a new branch to copy the master, to avoid overwriting the current master that is working.
The merge will be done in the master, however, the new branch will be working.

@mesonepigreco mesonepigreco merged commit c71dcf2 into SSCHAcode:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants