Merged
Conversation
jorgemarpa
reviewed
Jun 2, 2025
Collaborator
jorgemarpa
left a comment
There was a problem hiding this comment.
Loks good to me, will merge and push new version to PyPI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we add the option to return the orbital elements (eccentricity, inclination, perihelion distance) of the queried target.
Changes in this PR include:
verboseparameter. All columns get returned all the time.test_orbital_elements().A note on time scales
Horizons.ephemerides() assumes the input times are in UTC, whereas Horizons.elements() assumes the input times are in TDB. The output timestamps from these two queries don't match and it would be incorrect to merge the two tables assuming the times were the same.
Seeing as the orbital elements do not change appreciably during the length of a TESS sector, they definitely do not change significantly in the few minutes offset between UTC and TDB. Therefore, we take the average of the orbital elements during the time window and return those instead.