Feature: Reset autoplay timeout on manual slide switch #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reset according to options
Contributor
Author
|
Let me know if you think this solution correctly addresses the problem, or whether you think another approach would be more suitable :) |
Member
|
Hey @ERPedersen yeah this looks great! I'm going to give it a full review now and if all is good I'll release this with the upcoming patch - should be early next week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #184.
By resetting the autoplay interval when
goToPageis being called, we can accomplish this functionality. Because hovering over the element will reset the autoplay interval, it should only be run whenautoplayHoverPauseis false.I also added changes to the properties passed to the Autoplay example in the vue-play demos. Because
autoplayHoverPausehas a default value oftrue, it rendered the component with the same properties as in Autoplay, pause on hover.