Extend framework for sudo use-cases#242
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for local netgroups and sudoers aliases within the SSSD test framework. It adds new classes to manage /etc/netgroup and sudoers alias files in /etc/sudoers.d/, and updates LocalSudoRule to integrate with these aliases. A review comment identified a potential issue with the lexical sorting of sudoers alias files when using automatic ordering, suggesting the use of consistent zero-padding for file prefixes.
60d382f to
61e5cd6
Compare
|
The ci failures are unrelated. There is some issue in docs building and failing test_smartcard__su_as_local_user that probably has a fix in #239. |
|
Please check CI failures also. |
3ae4238 to
0f0b8ef
Compare
0f0b8ef to
b0d64b5
Compare
|
@jakub-vavra-cz you can add the following change to this PR as |
danlavu
left a comment
There was a problem hiding this comment.
The code is great, thank you. I don't like the docstrings though. I think it should be less verbose and concise. I made some comments as examples of what I think should change, but I didn't apply them to the entire file. Can you go through the docstrings with the comments in mind? Thanks.
7150a9a to
146234c
Compare
|
@madhuriupadhye I added the missing docstrings and refactored alias to allow changing order and handled duplicates for netgroup. |
madhuriupadhye
left a comment
There was a problem hiding this comment.
Looks good to me, just waiting to finish the CI.
danlavu
left a comment
There was a problem hiding this comment.
It's great, and I'll approve it, but I need a trivial change. There was a misunderstanding, type: never has . at the end. The pattern only applies to the :param: docstring.
sed '/:type/s/.$//' should do the trick.
0468727
146234c to
0468727
Compare
Cleanup of the implementation, docstring fixes from review. Reformatted with black.
0468727 to
845bb98
Compare
Did that for :type and :rtype that I both touched. Hopefully it is okay now. |
Implement sudo alias for local provider
Add local netgroups implementation