TOOLS: Double quote array expansions in sss_debuglevel #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise they're like $* and break on spaces.
This issue has been caught by coverity:
Defect type: SHELLCHECK_WARNING
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Contributor
|
This change is not necessary. Because "sssctl debug-level" does not take any
arguments which could be misinterpreted.
But it's better for follow best practices.
If you decide to touch this line then we can also call "exec"
instead of forking another child.
LS
|
This suggestion came from Lukáš Slebodník. The advantage of calling "exec" is to avoid forking another child of the process. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Contributor
Author
|
@lslebodn, thanks for the suggestion. Patch set has been updated. |
Contributor
|
Obvious, ACK |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise they're like $* and break on spaces.
This issue has been caught by coverity:
Defect type: SHELLCHECK_WARNING