Fix python3 issue in the integration test#540
Closed
sumit-bose wants to merge 1 commit intoSSSD:masterfrom
Closed
Conversation
With python3 comparisons between byte literals and strings will fail. To make sure assertions will pass the search results must be converted to (utf-8) strings first. Resolves https://pagure.io/SSSD/sssd/issue/3666
jhrozek
approved these changes
Mar 26, 2018
Contributor
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch the integration tests can run with python3.
To test make sure $(PYTHON2) in src/tests/intg/Makefile.am is replaced with
$(PYHTON3). Additionally the required python3 modules like e.g. python3-pytest,
python3-pyldap or python3-ldb must st installed.
At startup pytest will print a status line like
where you can check if python3 is really used for testing.