Skip to content

SSSCTL: don't require 'root' for "analyze" cmd -- 2.8 #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexey-tikhonov wants to merge 3 commits into from
Closed

SSSCTL: don't require 'root' for "analyze" cmd -- 2.8 #6444

alexey-tikhonov wants to merge 3 commits into from

Conversation

@alexey-tikhonov
Copy link
Member

@alexey-tikhonov alexey-tikhonov commented Nov 18, 2022

No description provided.

@alexey-tikhonov
TOOLS: don't export internal helpers
f42d30c 
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
(cherry picked from commit 6ef3aad)
@alexey-tikhonov
TOOLS: fixed handling of init error
2ec30e5 
Before execution of `tool_cmd_init()` `init_err` wasn't set,
so `sss_tools_handles_init_error()` check was a no-op.

Consequently, a proper check after `tool_cmd_init()` was missing.

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
(cherry picked from commit 7af46ba)
@alexey-tikhonov
SSSCTL: don't require 'root' for "analyze" cmd
fbdad39 
:relnote: `sssctl analyze` tool doesn't require anymore to be run under root.

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
(cherry picked from commit 9979140)
@alexey-tikhonov alexey-tikhonov mentioned this pull request Nov 18, 2022
Closed
@alexey-tikhonov
Copy link
Member Author

alexey-tikhonov commented Nov 18, 2022

Backport of #6426

ikerexxe
ikerexxe approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikerexxe ikerexxe self-assigned this Nov 18, 2022
@alexey-tikhonov
Copy link
Member Author

alexey-tikhonov commented Nov 18, 2022

Pushed PR: #6444

  • sssd-2-8
    • 581617c - SSSCTL: don't require 'root' for "analyze" cmd
    • bb97f89 - TOOLS: fixed handling of init error
    • 541cd67 - TOOLS: don't export internal helpers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikerexxe ikerexxe ikerexxe approved these changes

@justin-stephenson justin-stephenson justin-stephenson approved these changes

Assignees

@ikerexxe ikerexxe

@justin-stephenson justin-stephenson

Labels

Bugzilla Pushed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexey-tikhonov @ikerexxe @justin-stephenson