be: use be_is_offline for the main domain when asking for domain status#657
Closed
pbrezina wants to merge 1 commit intoSSSD:masterfrom
Closed
be: use be_is_offline for the main domain when asking for domain status#657pbrezina wants to merge 1 commit intoSSSD:masterfrom
pbrezina wants to merge 1 commit intoSSSD:masterfrom
Conversation
Contributor
|
Can you please add a FIXME comment to the code with short explanation and link to the https://pagure.io/SSSD/sssd/issue/3831 ? The if-else statements look a bit confusing as they are now. |
Member
Author
|
I updated the patch. |
The DOM_ACTIVE/INACTIVE flag is not used with the main domain as it is used only for subdomains. Resolves: https://pagure.io/SSSD/sssd/issue/3830
Contributor
|
ACK. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DOM_ACTIVE/INACTIVE flag is not used with the main domain as it
is used only for subdomains.
Resolves:
https://pagure.io/SSSD/sssd/issue/3830
This is a regression in sbus2 patches. I filed a ticket [1] to make the
usage of this flag consistent for all domains. I did not implement it as
part of this patch because I expect some caveats there so I kept this
patch simple.
[1] https://pagure.io/SSSD/sssd/issue/3831