Conversation
|
You forgot to rebuve build dependencies from spec file
and from ci.deps
contrib/ci/deps.sh: libaugeas-dev
contrib/sssd.spec.in:BuildRequires: augeas-devel
LS
|
c4a08ee to
78b6c96
Compare
|
Change done. Here is the fix up patch that in order to help the reviewer: |
|
|
||
| int ifp_component_change_debug_level_tmp(struct sbus_request *dbus_req, | ||
| void *data, | ||
| uint32_t arg_new_level); |
There was a problem hiding this comment.
Is there a reason why ifp_component_change_debug_level_tmp was not removed?
|
There is a tiny conflict due to change in There is also typo in commit message I think you also forgot to remove methods from |
libsss_config has been used only by OpenLMI and the project has been deprecated making, then, no sense to keep the support on SSSD. Distros that, for some reason, are still packing and distributing OpenLMI can stick to SSSD 1.14 branch. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
78b6c96 to
367332a
Compare
|
Suggestion taken and changes done, thanks for the review! |
|
You probably missed one comment. Is there a reason why Otherwise LGTM |
|
Ahh, I've just noticed that this function does not depend on auges/libsss_config. @pbrezina What do you think about remoing |
|
|
|
Just let you know |
libssss_config has been used only by OpenLMI and the project has been
deprecated making, then, no sense to keep the support on SSSD.
Distros that, for some reason, are still packing and distributing
OpenLMI can stick to SSSD 1.14 branch.
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com