Skip to content

BUILD: Drop libsss_config#79

Closed
fidencio wants to merge 1 commit intoSSSD:masterfrom
fidencio:wip/drop_libsss_config
Closed

BUILD: Drop libsss_config#79
fidencio wants to merge 1 commit intoSSSD:masterfrom
fidencio:wip/drop_libsss_config

Conversation

@fidencio
Copy link
Contributor

libssss_config has been used only by OpenLMI and the project has been
deprecated making, then, no sense to keep the support on SSSD.

Distros that, for some reason, are still packing and distributing
OpenLMI can stick to SSSD 1.14 branch.

Signed-off-by: Fabiano Fidêncio fidencio@redhat.com

@fidencio
Copy link
Contributor Author

@lslebodn
Copy link
Contributor

lslebodn commented Nov 11, 2016 via email

@fidencio fidencio force-pushed the wip/drop_libsss_config branch from c4a08ee to 78b6c96 Compare November 11, 2016 11:00
@fidencio
Copy link
Contributor Author

Change done. Here is the fix up patch that in order to help the reviewer:

[ffidenci@cat sssd]$ git diff HEAD
diff --git a/contrib/ci/deps.sh b/contrib/ci/deps.sh
index 9a7098c..387ad1f 100644
--- a/contrib/ci/deps.sh
+++ b/contrib/ci/deps.sh
@@ -69,7 +69,6 @@ if [[ "$DISTRO_BRANCH" == -debian-* ]]; then
         docbook-xsl
         gettext
         krb5-config
-        libaugeas-dev
         libc-ares-dev
         libcmocka-dev
         libcollection-dev
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index 2917629..f0b61ec 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -583,7 +583,6 @@ be used by Python applications.
 Summary: The D-Bus responder of the SSSD
 Group: Applications/System
 License: GPLv3+
-BuildRequires: augeas-devel
 Requires: sssd-common = %{version}-%{release}

 %description dbus


int ifp_component_change_debug_level_tmp(struct sbus_request *dbus_req,
void *data,
uint32_t arg_new_level);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why ifp_component_change_debug_level_tmp was not removed?

@lslebodn
Copy link
Contributor

There is a tiny conflict due to change in src/external/configlib.m4

There is also typo in commit message libssss_config and IMHO it might be better to use "BUILD"
as a component in commit title rather then LIBSSS_CONFIG.

I think you also forgot to remove methods from src/responder/ifp/ifp_iface.xml which is used
for generating C code.

libsss_config has been used only by OpenLMI and the project has been
deprecated making, then, no sense to keep the support on SSSD.

Distros that, for some reason, are still packing and distributing
OpenLMI can stick to SSSD 1.14 branch.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
@fidencio fidencio force-pushed the wip/drop_libsss_config branch from 78b6c96 to 367332a Compare November 23, 2016 14:38
@fidencio
Copy link
Contributor Author

Suggestion taken and changes done, thanks for the review!
I've just pushed a new version of the patch.

@fidencio fidencio changed the title LIBSSS_CONFIG: Drop libsss_config BUILD: Drop libsss_config Nov 23, 2016
@lslebodn
Copy link
Contributor

You probably missed one comment. Is there a reason why ifp_component_change_debug_level_tmp was not removed?

Otherwise LGTM

@lslebodn
Copy link
Contributor

Ahh, I've just noticed that this function does not depend on auges/libsss_config.
It just changes values in confdb. Which is temporary just by a chance and it would work only after restarting services. Do we need to keep it?

@pbrezina What do you think about remoing ChangeDebugLevelTemporarily?

@lslebodn
Copy link
Contributor

ChangeDebugLevelTemporarily does not depend on auges so it can be removed later.
master:

@lslebodn
Copy link
Contributor

Just let you know
the openlmi is orphaned and was removed from fedora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants