Tests: Handle SELinux in proxy provider tests #8348
Conversation
aborah-sudo
added
Waiting for review
Tests
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helper to temporarily disable SELinux for tests that require it. The implementation is sound, but can be improved for better maintainability and integration with pytest. I've suggested converting the new context manager into a pytest fixture. This will reduce code duplication across the test suite and make the tests cleaner. This also makes the newly added contextlib import unnecessary.
jakub-vavra-cz
left a comment
jakub-vavra-cz
left a comment
There was a problem hiding this comment.
The code looks nice and clean.
I suggest adding this to the framework with "host" instead of "client" so it can be more easily reused elsewhere.
aborah-sudo
force-pushed
the
fix_proxy
branch
from
02c9abd to
c5d2c2a
Compare
|
aborah-sudo
force-pushed
the
fix_proxy
branch
from
c5d2c2a to
dfdbd1f
Compare
|
I will create a new ticket to rewrite the tests to not use nss-pam-ldapd but some other nss and pam modules. |
jakub-vavra-cz
left a comment
jakub-vavra-cz
left a comment
There was a problem hiding this comment.
LGTM. The framework change SSSD/sssd-test-framework#227 needed is already merged just this ci did not register it.
jakub-vavra-cz
added
Accepted
Ready to push
Tests using nslcd fail under SELinux enforcing due to missing policies for test-only nss-pam-ldapd configuration. Add context manager to temporarily set permissive mode for affected tests. Reviewed-by: Jakub Vávra <jvavra@redhat.com>
3 participants
Tests using nslcd fail under SELinux enforcing due to missing policies for test-only nss-pam-ldapd configuration. Add context manager to temporarily set permissive mode for affected tests.