Config rules: allow 'ldap_subuid_*' attrs #8403
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
added
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces new ldap_subuid_* and ldap_subgid_* configuration options in src/config/cfg_rules.ini. However, these new options do not appear to have corresponding definitions in src/config/SSSDConfig/sssdoptions.py. This omission can lead to issues with configuration parsing, documentation, and overall system understanding of these new parameters.
alexey-tikhonov
force-pushed
the
subid-attrs-cfgrules
branch
from
3692952 to
680ca14
Compare
sumit-bose
approved these changes
Jan 27, 2026
Contributor
sumit-bose
left a comment
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
thank you for the fix, the list is the same as in the source code and man page, ACK.
bye,
Sumit
Reviewed-by: Sumit Bose <sbose@redhat.com>
Contributor
sssd-bot
force-pushed
the
subid-attrs-cfgrules
branch
from
680ca14 to
9ef3a9e
Compare
This was referenced Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.