LDAP: free tmp var within the loop#8484
Merged
alexey-tikhonov merged 1 commit intoSSSD:masterfrom Mar 2, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies sdap_add_incomplete_groups to free the msg variable within the processing loop, which is intended to reduce memory pressure when handling a large number of groups. The msg variable is also initialized to NULL to ensure safe operation. I have reviewed the changes and have no further comments.
alexey-tikhonov
added
Waiting for review
Trivial
inside `sdap_add_incomplete_groups()` to avoid memory pressure / cache trashing if handling large groups set. Reviewed-by: Tomáš Halman <thalman@redhat.com>
Contributor
sssd-bot
force-pushed
the
incomplete-groups-again-2
branch
from
1a8aefa to
c7410c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inside
sdap_add_incomplete_groups()to avoid memory pressure/ cache trashing if handling large groups set.