Skip to content

KRB5: log level adjusted#8548

Merged
alexey-tikhonov merged 1 commit intoSSSD:masterfrom
alexey-tikhonov:kpasswd-log
Mar 25, 2026
Merged

KRB5: log level adjusted#8548
alexey-tikhonov merged 1 commit intoSSSD:masterfrom
alexey-tikhonov:kpasswd-log

Conversation

@alexey-tikhonov
Copy link
Copy Markdown
Member

No description provided.

@alexey-tikhonov alexey-tikhonov added Trivial A single reviewer is sufficient to review the Pull Request backport-to-sssd-2-9 labels Mar 25, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the logging level in src/providers/krb5/krb5_init.c from SSSDBG_FATAL_FAILURE to SSSDBG_CONF_SETTINGS. This change applies to a debug message indicating that the krb5_kpasswd option is missing while KDC servers are explicitly set, which is a more appropriate severity for a configuration-related informational message. There are no review comments to address.

Copy link
Copy Markdown
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the patch, ACK.

bye,
Sumit

@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review March 25, 2026 10:10
Resolves: SSSD#8531
Reviewed-by: Sumit Bose <sbose@redhat.com>
@sssd-bot
Copy link
Copy Markdown
Contributor

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
🟢 ci / system (fedora-45) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@alexey-tikhonov alexey-tikhonov merged commit 8631c02 into SSSD:master Mar 25, 2026
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted backport-to-sssd-2-9 Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants