[autobackport: sssd-2-11] rewriting memcache tests#8587
Merged
danlavu merged 2 commits intoSSSD:sssd-2-11from Apr 14, 2026
Merged
[autobackport: sssd-2-11] rewriting memcache tests#8587danlavu merged 2 commits intoSSSD:sssd-2-11from
danlavu merged 2 commits intoSSSD:sssd-2-11from
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the integration-level memory cache tests and refactors the system-level memcache tests in src/tests/system/tests/test_memcache.py. The refactor introduces several helper functions and leverages pytest parametrization to consolidate test logic for users, groups, and initgroups, improving maintainability. However, a critical issue was found in src/tests/intg/Makefile.am, which contains unresolved merge conflict markers that must be fixed to ensure a valid build.
b9d84a4 to
8d4f0d5
Compare
andreboscatto
approved these changes
Apr 14, 2026
Contributor
|
After re-running CI failed jobs, getting same failures. |
Member
sssd-2-11 branch CI is in a poor state. |
madhuriupadhye
approved these changes
Apr 14, 2026
added 2 commits
April 14, 2026 13:50
* parametrized test cases * added colliding hash test case * remove poor test scenarios (cherry picked from commit 428e613) Reviewed-by: Andre Boscatto <aboscatt@redhat.com> Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com>
(cherry picked from commit 7d9bdd5) Reviewed-by: Andre Boscatto <aboscatt@redhat.com> Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com>
Contributor
Author
8d4f0d5 to
cb1f456
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8485 rewriting memcache tests to branch sssd-2-11, created by @danlavu.
Caution
@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
428e613 - Reworked memcache tests * parametrized test cases * added colliding hash test case * remove poor test scenarios
7d9bdd5 - removing intg memcache tests
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body