Skip to content

More trivial spelling/grammatical fixes#8591

Merged
justin-stephenson merged 1 commit intoSSSD:masterfrom
striker314:spelling-updates_04-10-26
Apr 14, 2026
Merged

More trivial spelling/grammatical fixes#8591
justin-stephenson merged 1 commit intoSSSD:masterfrom
striker314:spelling-updates_04-10-26

Conversation

@striker314
Copy link
Copy Markdown
Contributor

@striker314 striker314 commented Apr 10, 2026

No functional code was harmed in the changing of these files.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive cleanup of typos in comments, documentation, and log messages across the codebase. While most changes are beneficial, a correction in src/db/sysdb_ops.c was identified as inaccurate because it replaces the standard POSIX function name getgrnam with a non-existent one.

Comment thread src/db/sysdb_ops.c Outdated
Copy link
Copy Markdown
Contributor Author

@striker314 striker314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected mistake in [src/db/sysdb_ops.c]

@alexey-tikhonov
Copy link
Copy Markdown
Member

alexey-tikhonov commented Apr 13, 2026

@striker314, please squash two commits (or discard 2nd and amend 1st).

@striker314
Copy link
Copy Markdown
Contributor Author

I checked over the changes for whitespace or double semicolons and am not finding an issue for why distcheck fails.

@alexey-tikhonov
Copy link
Copy Markdown
Member

Thank you, ACK.

This won't apply cleanly to sssd-2-9 but I'll keep the label, it shouldn't be difficult to amend automated backport.

Copy link
Copy Markdown
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you for the fixes.

…d in the changing of these files.

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
@sssd-bot
Copy link
Copy Markdown
Contributor

The pull request was accepted by @justin-stephenson with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟡 ci / system (fedora-44) (in_progress)
🟢 ci / system (fedora-45) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the spelling-updates_04-10-26 branch from ad34ae0 to 2df1034 Compare April 14, 2026 13:14
@justin-stephenson justin-stephenson merged commit 3501963 into SSSD:master Apr 14, 2026
10 of 15 checks passed
@striker314 striker314 deleted the spelling-updates_04-10-26 branch April 14, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants