[autobackport: sssd-2-9] KCM: fix use-after-free in kcm_read_options()#8594
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the kcm_read_options function in src/responder/kcm/kcm_renew.c to correctly transfer ownership of the renew_intv pointer to the specified memory context using talloc_steal. There are no review comments to address, and I have no further feedback to provide.
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
backport matches original version, ACK.
bye,
Sumit
The `renew_intv` string was allocated under tmp_ctx but not re-linked to mem_ctx before tmp_ctx was freed. Assisted-By: Claude Code (Opus 4.6) Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit 0100b1c)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
f2f88e8 to
c5a2b48
Compare
This is an automatic backport of PR#8592 KCM: fix use-after-free in
kcm_read_options()to branch sssd-2-9, created by @alexey-tikhonov.Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
0100b1c - KCM: fix use-after-free in
kcm_read_options()Backported commits
kcm_read_options()Original Pull Request Body
The
renew_intvstring was allocated under tmp_ctx but not re-linked to mem_ctx before tmp_ctx was freed.Assisted-By: Claude Code (Opus 4.6)
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2457467