[backport] Tests: Housekeeping and Clean Sweep of Sevice/Logging suite#8609
Merged
danlavu merged 1 commit intoSSSD:sssd-2-9from Apr 21, 2026
Merged
[backport] Tests: Housekeeping and Clean Sweep of Sevice/Logging suite#8609danlavu merged 1 commit intoSSSD:sssd-2-9from
danlavu merged 1 commit intoSSSD:sssd-2-9from
Conversation
Merged tests for sssd offline message in logs and syslog. Split backend offline(unreachable) and dns resolution error scenario. Check that user login does not generate logs on default debug level extended to all providers. Added link to debug level documentation. Dropped references to (now-irrelevant) bugzillas in rewritten tests. Skipping test_logging__user_logins_are_not_written_to_logs as updating log level of the messages is low priority.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors and expands the SSSD logging test suite, adding new test cases for runtime debug level adjustments and improving the validation of offline error reporting by using firewall rules to simulate network issues. A review comment points out a potential issue in the offline error test where the removal of a journal clearing step could lead to false positive results by detecting log entries from previous test runs.
jakub-vavra-cz
changed the title
jakub-vavra-cz
added
Waiting for review
Trivial
danlavu
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of https://github.com/SSSD/sssd/pull/8512/commits .
Merged tests for sssd offline message in logs and syslog. Split backend offline(unreachable) and dns resolution error scenario. Check that user login does not generate logs on default debug level extended to all providers. Added link to debug level documentation. Dropped references to (now-irrelevant) bugzillas in rewritten tests.
Skipping test_logging__user_logins_are_not_written_to_logs as updating log level of the messages is low priority.