[autobackport: sssd-2-9] pam: gate PAC indicator code on BUILD_SAMBA

[sssd-bot]

This is an automatic backport of PR#8620 pam: gate PAC indicator code on BUILD_SAMBA to branch sssd-2-9, created by @padelsbach.

Caution

@padelsbach The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8620-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8620-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8620-to-sssd-2-9 --force

---

Original commits
d0becea - pam: gate PAC indicator code on BUILD_SAMBA

Backported commits

• 63ab500 - CONFLICT! pam: gate PAC indicator code on BUILD_SAMBA

Conflicting Files Information (check for deleted and re-added files)

• CONFLICT! pam: gate PAC indicator code on BUILD_SAMBA

On branch SSSD-sssd-backport-pr8620-to-sssd-2-9
You are currently cherry-picking commit d0beceaa1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/man/sssd.conf.5.xml
	modified:   src/responder/pam/pamsrv.c
	modified:   src/responder/pam/pamsrv_gssapi.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Makefile.am
	both modified:   src/man/Makefile.am

---

Original Pull Request Body

Commit 1f680ed added ad_pac_common.c and $(NDR_KRB5PAC_LIBS) to sssd_pam unconditionally. So when building --without-samba, sssd_pam fails to link with undefined references to ndr_pull_init_blob and ndr_pull_PAC_DATA.

This change qualifies those additions with BUILD_SAMBA so the PAC indicator feature is compiled in only when samba support is enabled.

[gemini-code-assist]

Code Review

This pull request gates PAC indicator functionality and its dependencies behind the BUILD_SAMBA conditional across the build system, man pages, and PAM responder. While the logic for conditional compilation appears correct, the PR contains critical issues: unresolved merge conflict markers are present in Makefile.am and src/man/Makefile.am, which will cause build failures. Furthermore, new test targets are defined but not registered for execution, and several man page conditionals were lost in the conflict, potentially leading to incomplete documentation.

[alexey-tikhonov]

'system/c9s':

  /usr/include/gdm/gdm-pam-extensions.h:24:10: fatal error: gdm-choice-list-pam-extension.h: No such file or directory
     24 | #include "gdm-choice-list-pam-extension.h"
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[sumit-bose]

Hi,

the backport matches the original version of the patch, ACK.

bye,
Sumit

[sssd-bot]

The pull request was accepted by @alexey-tikhonov with the following PR CI status:

---

🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 Build / make-distcheck (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)

---

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.