PAM/PASSKEY: avoid unnecessary memcpy#8630
Merged
alexey-tikhonov merged 1 commit intoSSSD:masterfrom Apr 22, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the pam_passkey_child_read_data function in pamsrv_passkey.c to pass the data buffer directly to sss_authtok_set_passkey_reply. This change eliminates the need for manual memory allocation, copying, and null-termination of a temporary string. Additionally, the buffer length check was updated to handle non-positive values. I have no feedback to provide.
sumit-bose
approved these changes
Apr 22, 2026
Contributor
sumit-bose
left a comment
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
thank you for the code-reduction, ACK.
bye,
Sumit
Member
Author
|
Note: Covscan is clean. |
alexey-tikhonov
added
Waiting for review
and removed
coverity
`sss_authtok_set_passkey_reply()` -> `sss_authtok_set_string()` handles non NULL-terminated buffer correctly. Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
Contributor
sssd-bot
force-pushed
the
pamsrv-passkey-cleanup
branch
from
6dacebd to
6b6d131
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sss_authtok_set_passkey_reply()->sss_authtok_set_string()handles non NULL-terminated buffer correctly.