[autobackport: sssd-2-9] IPA: memory leak fixed#8637
[autobackport: sssd-2-9] IPA: memory leak fixed#8637alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies src/providers/ipa/ipa_s2n_exop.c to use a specific memory context for base64 decoding and introduces explicit memory cleanup in error handling paths. The review feedback correctly identifies that the newly added deallocation calls for name and values are redundant and would result in double-free errors, as these variables are already managed at the end of the processing loop.
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
backport and original version match, ACK.
I think Gemini's comments are wrong because it didn't take the return immediately after the free-s into account.
bye,
Sumit
Result allocated by `sss_base64_decode()` on NULL context was never freed. Reviewed-by: Alejandro López <allopez@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit 958a186)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
05ed94a to
088f9eb
Compare
This is an automatic backport of PR#8632 IPA: memory leak fixed to branch sssd-2-9, created by @alexey-tikhonov.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
958a186 - IPA: memory leak fixed
Backported commits
Original Pull Request Body
Result allocated by
sss_base64_decode()on NULL context was never freed.