[autobackport: sssd-2-9] tests: poll for KCM TGT renewal instead of fixed sleep#8656
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes a flaky test marker and updates the KCM TGT renewal test to use a polling mechanism instead of a fixed sleep, which improves test reliability. However, the changes currently include unresolved merge conflict markers in src/tests/system/tests/test_kcm.py that must be removed for the code to be functional.
60c6b16 to
b3b9819
Compare
test_kcm__tgt_renewal_updates_ticket_as_configured no longer uses a fixed sleep(5) and flaky retries. The test now polls klist every 0.5s and asserts renewal by checking that TGT start or end time advances, with a detailed failure message that prints both initial and last timestamps. To match KCM renewal behavior (renewal only starts after roughly half the ticket lifetime), the test uses a short renewable ticket (-r 5s -l 5s) and a bounded polling window (9s) so it stays fast while still waiting long enough for renewal to be attempted. Also removed the temporary CI comment and the flaky marker from this test. Assited by: Cursor(Claude Opus 4.6) Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com> Reviewed-by: Scott Poore <spoore@redhat.com>
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
b3b9819 to
9d832be
Compare
This is an automatic backport of PR#8650 tests: poll for KCM TGT renewal instead of fixed sleep to branch sssd-2-9, created by @madhuriupadhye.
Caution
@madhuriupadhye The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
233db39 - tests: poll for KCM TGT renewal instead of fixed sleep
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body
test_kcm__tgt_renewal_updates_ticket_as_configured no longer uses a fixed sleep(5) and flaky retries.
The test now polls klist every 0.5s and asserts renewal by checking that TGT start or end time advances, with a detailed failure message that prints both initial and last timestamps.
To match KCM renewal behavior (renewal only starts after roughly half the ticket lifetime), the test uses a short renewable ticket (-r 5s -l 5s) and a bounded polling window (9s) so it stays fast while still waiting long enough for renewal to be attempted.
Also removed the temporary CI comment and the flaky marker from this test.