Skip to content

[autobackport: sssd-2-9] tests: poll for KCM TGT renewal instead of fixed sleep#8656

Merged
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8650-to-sssd-2-9
Apr 28, 2026
Merged

[autobackport: sssd-2-9] tests: poll for KCM TGT renewal instead of fixed sleep#8656
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8650-to-sssd-2-9

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8650 tests: poll for KCM TGT renewal instead of fixed sleep to branch sssd-2-9, created by @madhuriupadhye.

Caution

@madhuriupadhye The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8650-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8650-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8650-to-sssd-2-9 --force

Original commits
233db39 - tests: poll for KCM TGT renewal instead of fixed sleep

Backported commits

  • 60c6b16 - CONFLICT! tests: poll for KCM TGT renewal instead of fixed sleep

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! tests: poll for KCM TGT renewal instead of fixed sleep
On branch SSSD-sssd-backport-pr8650-to-sssd-2-9
You are currently cherry-picking commit 233db39fc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/tests/system/tests/test_kcm.py

no changes added to commit (use "git add" and/or "git commit -a")

Original Pull Request Body

test_kcm__tgt_renewal_updates_ticket_as_configured no longer uses a fixed sleep(5) and flaky retries.
The test now polls klist every 0.5s and asserts renewal by checking that TGT start or end time advances, with a detailed failure message that prints both initial and last timestamps.

To match KCM renewal behavior (renewal only starts after roughly half the ticket lifetime), the test uses a short renewable ticket (-r 5s -l 5s) and a bounded polling window (9s) so it stays fast while still waiting long enough for renewal to be attempted.
Also removed the temporary CI comment and the flaky marker from this test.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a flaky test marker and updates the KCM TGT renewal test to use a polling mechanism instead of a fixed sleep, which improves test reliability. However, the changes currently include unresolved merge conflict markers in src/tests/system/tests/test_kcm.py that must be removed for the code to be functional.

Comment thread src/tests/system/tests/test_kcm.py Outdated
Comment thread src/tests/system/tests/test_kcm.py Fixed
@madhuriupadhye madhuriupadhye force-pushed the SSSD-sssd-backport-pr8650-to-sssd-2-9 branch from 60c6b16 to b3b9819 Compare April 28, 2026 13:59
@madhuriupadhye madhuriupadhye marked this pull request as ready for review April 28, 2026 14:00
Copy link
Copy Markdown
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-tikhonov alexey-tikhonov removed their request for review April 28, 2026 14:43
@alexey-tikhonov alexey-tikhonov removed their assignment Apr 28, 2026
@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. Accepted labels Apr 28, 2026
test_kcm__tgt_renewal_updates_ticket_as_configured
no longer uses a fixed sleep(5) and flaky retries.
The test now polls klist every 0.5s and asserts renewal
by checking that TGT start or end time advances,
with a detailed failure message that prints both
initial and last timestamps.

To match KCM renewal behavior (renewal only starts
after roughly half the ticket lifetime),
the test uses a short renewable ticket (-r 5s -l 5s) and
a bounded polling window (9s) so it stays fast while still
waiting long enough for renewal to be attempted.
Also removed the temporary CI comment and the flaky marker from this test.

Assited by: Cursor(Claude Opus 4.6)

Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
Reviewed-by: Scott Poore <spoore@redhat.com>
@sssd-bot
Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8650-to-sssd-2-9 branch from b3b9819 to 9d832be Compare April 28, 2026 14:46
@alexey-tikhonov alexey-tikhonov merged commit f0f9bdf into SSSD:sssd-2-9 Apr 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants