Skip to content

[autobackport: sssd-2-9] Smartcard multi token tests#8662

Open
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8519-to-sssd-2-9
Open

[autobackport: sssd-2-9] Smartcard multi token tests#8662
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8519-to-sssd-2-9

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8519 Smartcard multi token tests to branch sssd-2-9, created by @krishnavema.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8519-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8519-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8519-to-sssd-2-9 --force

Original commits
e5b6597 - tests: implement multi-token support for smart card authentication

Backported commits

  • 4df5b07 - tests: implement multi-token support for smart card authentication

Original Pull Request Body

Reviewed-by: Scott Poore <spoore@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
(cherry picked from commit e5b6597)
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new system tests for smart card authentication scenarios involving multiple tokens. It includes a helper function to set up two SoftHSM tokens and three new test cases covering matches on the first token, the second token, and both tokens. The review feedback correctly identifies that the new tests are missing the @pytest.mark.builtwith(client="virtualsmartcard") marker, which is necessary to ensure the tests are skipped in environments without the required smart card dependencies.

Comment thread src/tests/system/tests/test_smartcard.py
Comment thread src/tests/system/tests/test_smartcard.py
Comment thread src/tests/system/tests/test_smartcard.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants