[autobackport: sssd-2-12] Smartcard multi token tests#8664
Open
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-12from
Open
[autobackport: sssd-2-12] Smartcard multi token tests#8664sssd-bot wants to merge 1 commit intoSSSD:sssd-2-12from
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-12from
Conversation
Reviewed-by: Scott Poore <spoore@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit e5b6597)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces system tests for smart card authentication scenarios involving multiple tokens. It adds a helper function setup_two_tokens to initialize SoftHSM tokens with IPA-signed certificates and includes three new test cases covering scenarios where a valid certificate is on the first token, the second token, or both tokens. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8519 Smartcard multi token tests to branch sssd-2-12, created by @krishnavema.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
e5b6597 - tests: implement multi-token support for smart card authentication
Backported commits
Original Pull Request Body