[autobackport: sssd-2-13] Smartcard multi token tests#8665
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces system tests for smartcard authentication scenarios involving multiple SoftHSM tokens. It includes a helper function for token setup and three test cases covering scenarios where a valid certificate is on the first token, the second token, or both. A bug was identified in the parametrized test test_smartcard__two_tokens_match_on_both, where attempting to add the same IPA user in multiple iterations would cause a failure; a suggestion was provided to use unique usernames for each iteration.
sumit-bose
left a comment
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
original and backport matches, ACK.
bye,
Sumit
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
LGTM. Approving since code is the same and the original system tests ran on Fedora 45 which has sssd-2.13.
Reviewed-by: Scott Poore <spoore@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit e5b6597)
|
The pull request was accepted by @spoore1 with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8519-to-sssd-2-13
branch
from
318ba3b to
750243b
Compare
5 participants
This is an automatic backport of PR#8519 Smartcard multi token tests to branch sssd-2-13, created by @krishnavema.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
e5b6597 - tests: implement multi-token support for smart card authentication
Backported commits
Original Pull Request Body