[autobackport: sssd-2-13] sdap: let callers mark SSSD as offline if kinit fails#8701
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the LDAP provider's connection handling to ensure SSSD enters an offline state upon failing to obtain a Kerberos TGT by setting the retry flag to false and returning an EIO error. It also introduces new system tests to validate that SSSD correctly transitions to offline status when Kerberos or LDAP services are unreachable. I have no feedback to provide.
sumit-bose
left a comment
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
backport and original patch match, ACK.
bye,
Sumit
The callers expected that ret == EIO and can_retry == false to bring SSSD to an offline state. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit c5b631e)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8675-to-sssd-2-13
branch
from
805235a to
a836b54
Compare
4 participants
This is an automatic backport of PR#8675 sdap: let callers mark SSSD as offline if kinit fails to branch sssd-2-13, created by @pbrezina.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
c5b631e - sdap: let callers mark SSSD as offline if kinit fails
Backported commits
Original Pull Request Body
The callers expected that ret == EIO and can_retry == false to bring
SSSD to an offline state.