Skip to content

[autobackport: sssd-2-13] tests: Clarify approx match filter#8730

Merged
justin-stephenson merged 1 commit into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8714-to-sssd-2-13
May 26, 2026
Merged

[autobackport: sssd-2-13] tests: Clarify approx match filter#8730
justin-stephenson merged 1 commit into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8714-to-sssd-2-13

Conversation

@sssd-bot

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8714 tests: Clarify approx match filter to branch sssd-2-13, created by @justin-stephenson.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8714-to-sssd-2-13
git checkout SSSD-sssd-backport-pr8714-to-sssd-2-13
git push sssd-bot SSSD-sssd-backport-pr8714-to-sssd-2-13 --force

Original commits
21674dd - tests: Clarify approx match filter

Backported commits

  • e27b38d - tests: Clarify approx match filter

Original Pull Request Body

Debugging this test for an unrelated issue (new failover) lead to several questions about 'approximate match' filter, adding some comments to make it more clear after some investigation.

@sssd-bot sssd-bot requested a review from thalman May 25, 2026 13:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds explanatory comments to the LDAP access control filter tests in src/tests/system/tests/test_access_control_ldap_filter.py. These comments document the provider-specific behavior of approximate match filters for AD, Samba, and 389ds, and provide context on how these filters affect authentication results for specific test users. I have no feedback to provide as there were no review comments.

@thalman thalman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctly backported, ACK

Reviewed-by: Tomáš Halman <thalman@redhat.com>
(cherry picked from commit 21674dd)
@sssd-bot

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @justin-stephenson with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8714-to-sssd-2-13 branch from e27b38d to 69a99f3 Compare May 26, 2026 14:19
@justin-stephenson justin-stephenson merged commit eecbb52 into SSSD:sssd-2-13 May 26, 2026
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants