[autobackport: sssd-2-13] tests: Clarify approx match filter#8730
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds explanatory comments to the LDAP access control filter tests in src/tests/system/tests/test_access_control_ldap_filter.py. These comments document the provider-specific behavior of approximate match filters for AD, Samba, and 389ds, and provide context on how these filters affect authentication results for specific test users. I have no feedback to provide as there were no review comments.
thalman
left a comment
There was a problem hiding this comment.
correctly backported, ACK
Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit 21674dd)
|
The pull request was accepted by @justin-stephenson with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
e27b38d to
69a99f3
Compare
This is an automatic backport of PR#8714 tests: Clarify approx match filter to branch sssd-2-13, created by @justin-stephenson.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
21674dd - tests: Clarify approx match filter
Backported commits
Original Pull Request Body
Debugging this test for an unrelated issue (new failover) lead to several questions about 'approximate match' filter, adding some comments to make it more clear after some investigation.