Skip to content

[이안] Chapter 9. API & Paging #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eeeeeaaan merged 4 commits into from
May 28, 2025
Merged

[이안] Chapter 9. API & Paging #48

eeeeeaaan merged 4 commits into from
May 28, 2025

Conversation

@eeeeeaaan
Copy link

@eeeeeaaan eeeeeaaan commented May 26, 2025 •
edited
Loading

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@eeeeeaaan eeeeeaaan requested review from 2ghrms, junekyu02 and ri-mmu May 26, 2025 15:42
@eeeeeaaan eeeeeaaan added the ✨Chapter09 챕터 9 label May 26, 2025
@eeeeeaaan eeeeeaaan linked an issue May 26, 2025 that may be closed by this pull request
[이안] Chapter 9. API & Paging #44
Open
ri-mmu
ri-mmu approved these changes May 28, 2025
View reviewed changes
Copy link

@ri-mmu ri-mmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

junekyu02
junekyu02 approved these changes May 28, 2025
View reviewed changes
Copy link

@junekyu02 junekyu02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

2ghrms
2ghrms approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@2ghrms 2ghrms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!!

src/main/java/umc/spring/validation/validator/MarketExistValidator.java
@RequiredArgsConstructor
public class MarketExistValidator implements ConstraintValidator<ExistMarket, String> {
private final MarketRepository marketRepository;

Copy link
Member

@2ghrms 2ghrms May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialize 추가해보셔요

@eeeeeaaan eeeeeaaan merged commit f9528e4 into ean/main May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2ghrms 2ghrms 2ghrms approved these changes

@junekyu02 junekyu02 junekyu02 approved these changes

@ri-mmu ri-mmu ri-mmu approved these changes

Assignees

No one assigned

Labels

✨Chapter09 챕터 9

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[이안] Chapter 9. API & Paging

5 participants

@eeeeeaaan @2ghrms @junekyu02 @ri-mmu