Add a generic return type to autoreleasepool()#68
Merged
SSheldon merged 1 commit intoSSheldon:masterfrom Jul 24, 2018
Merged
Conversation
This is a general usability improvement that lets users easily get values out of the closure.
Contributor
Author
kvark
approved these changes
Jul 23, 2018
Owner
|
Thanks! Agreed, I'm going to keep this in the 0.2.x version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a general usability improvement that lets users
easily get values out of the closure.
While this is technically a breaking change I think it would be best to let it slide. I don't think there are any users of autoreleasepool() yet and even if there are this change is unlikely to break them.