Fix #315#319
Open
samatstariongroup wants to merge 2 commits into
Open
Conversation
…d needs to be fixed again. The old state was producing infinite loop. For now, the redefinition mechanism is broken and had to be restored. Ownership guard is ok but most of changes on the PropertyHelper.cs breaks UML redefintion rules. Following task is to revert those change to be on a UML strict redefintiion rule but update extend implemenation to not enter into infinite loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315.
What
Upgrade
uml4net8.1.2 -> 8.2.1, which resolves bare same-document hrefs (href="#id") forsubsettedProperty/redefinedProperty, so the previously-dropped secondary subset/redefine references now reach generated code.Changes
uml4net.HandleBars,uml4net.xmi.Extensions.EnterpriseArchitect,uml4net.Reportingto 8.2.1.PropertyHelper(DTO/POCO class emit) exposed by 8.2.1: enum-typed default values now resolve as "different than default", which made the raw-value branch emit invalid C# (= public;). The enum-default branch is now checked first ->= VisibilityKind.Public;.AutoGenDto,AutoGenPoco, JSONAutoGenDeSerializer, XMIAutoGenWriters, DALAutoGenPocoExtension, and sync the stale generatedExtensions/AutoGenExtensions/ElementExtensions.cs. Serializer/Comparer/MessagePack/XMI-Reader/ElementFactory surfaces access via interface types and were unaffected.Expectedgolden files.Verification
IUsage.directedUsagenow carries both thedirectedFeatureandusagesubsets.