Fix reading of "MAX", "MIN" attributes #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2 +/- ##
============================================
Coverage 99.28% 99.28%
============================================
Files 24 24
Lines 1113 1113
============================================
Hits 1105 1105
Misses 8 8Continue to review full report at Codecov.
|
Member
|
thanks for the contributions! agreed on adding test data later. I hope i can help with that. |
samatstariongroup
requested changes
Jun 1, 2018
| { | ||
| this.Max = max; | ||
| } | ||
| if (double.TryParse(reader.GetAttribute("MIN"), out double min)) |
Member
There was a problem hiding this comment.
styling: please add empty line after 77
| { | ||
| this.Max = max; | ||
| } | ||
| if (int.TryParse(reader.GetAttribute("MIN"), out int min)) |
Member
There was a problem hiding this comment.
styling: please add empty line after 77
…ER" and "DATATYPE-DEFINITION-REAL"
samatstariongroup
approved these changes
Jun 2, 2018
Member
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix reading of "MAX", "MIN" attributes for "DATATYPE-DEFINITION-INTEGER" and "DATATYPE-DEFINITION-REAL"
I plan to add tests later in another PR. Sorry, but I do not have any free time at this moment.