[Update] lower Microsoft.Extensions.Logging.Abstractions floor to 6.0.0#77
Merged
Merged
Conversation
The core library only uses logging APIs present since 6.0.0, yet pinned the floor at 10.0.8. A PackageReference version is a transitive minimum, so the high floor forced every consumer onto the 10.x line and undermined the broad reach of the netstandard2.0 target. Lower the floor to 6.0.0, document the rationale in the csproj, and add a README note explaining how .NET 8/10 consumers can float or pin the dependency.
samatstariongroup
force-pushed
the
lower-logging-abstractions-floor
branch
from
43307bb to
b72fed5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The core
ReqIFSharplibrary pinnedMicrosoft.Extensions.Logging.Abstractionsat10.0.8, but only uses logging APIs that have existed since6.0.0(ILogger/ILoggerFactory,CreateLogger<T>,NullLogger<T>, and theLog*message-template extensions).A
PackageReferenceversion is a transitive minimum, so the high floor forced every consumer onto the10.xline — at odds with the broad reach thenetstandard2.0target is meant to provide. This PR lowers the floor to6.0.0while letting NuGet float consumers up when their own graph requires a newer version.Changes
ReqIFSharp/ReqIFSharp.csproj— floorMicrosoft.Extensions.Logging.Abstractionsat6.0.0, with an explanatory comment so the low floor isn't "fixed" later by mistake.README.md— new Dependencies section explaining the floor and how .NET 8/10 consumers can float or explicitly pin the dependency.Verification
dotnet build ReqIFSharp/ReqIFSharp.csproj -c Release— succeeds, 0 warnings / 0 errors onnetstandard2.0.dotnet list packageconfirms the dependency resolves at6.0.0.net10.0test projects still pull10.xtransitively).