Port anti-generic to V2#682
Merged
rgantzos merged 2 commits intoSTForScratch:mainfrom Oct 10, 2023
Merged
Conversation
Contributor
Author
|
I think I broke dynamic re-enable. This will probably also need some more testing to make sure the algorithm hasn't been accidentally changed. |
Member
|
@rgantzos this still isn't merged lol |
Collaborator
|
Looks good, I'll merge this. I'll fix any other system issues separately. |
rgantzos
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also simplified the title matching by combining the if statements and removing redundant matches. I also changed the way newly loaded projects are handled and adjusted the warning. I didn't change the similarity functions because I'm still not entirely sure what that's supposed to do.