Skip to content

Namespaces#238

Merged
gtback merged 2 commits intomasterfrom
namespaces
Feb 25, 2015
Merged

Namespaces#238
gtback merged 2 commits intomasterfrom
namespaces

Conversation

@bworrell
Copy link
Contributor

This pull request addresses #224 and to some extent #200.

Updated behavior of ns_dict and schemaloc_dict parameters for Entity.to_xml():

  • Namespace definitions (alias mappings) and schema locations that do not conflict with python-stix defaults are passed through to the document
  • Namespace alias mappings and schema location mappings which are already found in python-stix are ignored--python-stix values are used instead.

Bryan Worrell added 2 commits February 12, 2015 18:19
* python-stix defaults override any input values.
* Any non python-stix|cybox|maec value will appear in the output
  xml.
@landscape-bot
Copy link

Code Health
Repository health decreased by 0.10% when pulling 3d56f0b on namespaces into ecdca61 on master.

@bworrell bworrell mentioned this pull request Feb 13, 2015
@gtback gtback self-assigned this Feb 13, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally find the previous style more intuitive, even though it's a couple more lines. I'm ok with this, though.

@gtback
Copy link
Contributor

gtback commented Feb 25, 2015

Looks good to me. 👍 for all the additional comments, which help me actually understand what the finalize method is doing. Thanks, @bworrell

gtback added a commit that referenced this pull request Feb 25, 2015
@gtback gtback merged commit 0ef159f into master Feb 25, 2015
@gtback gtback deleted the namespaces branch February 25, 2015 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants