Skip to content

CIQ Identity 3.0 - update to_dict and from_dict to include organisation_info#293

Merged
gtback merged 2 commits intoSTIXProject:masterfrom
joewaltonPurple:organisation_info
Jul 6, 2016
Merged

CIQ Identity 3.0 - update to_dict and from_dict to include organisation_info#293
gtback merged 2 commits intoSTIXProject:masterfrom
joewaltonPurple:organisation_info

Conversation

@joewaltonPurple
Copy link

Include organisation_info in the to_dict and from_dict methods on CIQIdentity3_0, This replicates the functionality already seen in the the to_obj and from_obj.

@joewaltonPurple
Copy link
Author

Hi @bworrell, would it be possible for you to look at this pull request? Thanks Joe.

@gtback
Copy link
Contributor

gtback commented Jul 5, 2016

Thanks, @joewaltonPurple! Can you add some data to stix/test/extensions/identity/ciq_identity_3_0_test.py to test this change?

By the way, @bworrell isn't working on STIX anymore, so feel free to bug me instead 😀

@joewaltonPurple
Copy link
Author

Cheers @gtback that should be all done.

@gtback
Copy link
Contributor

gtback commented Jul 6, 2016

Looks great! Thanks, @joewaltonPurple

@gtback gtback merged commit 8ba60c4 into STIXProject:master Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants