Edge7 v1.1.1.3#300
Closed
dandye wants to merge 20 commits intoSTIXProject:masterfrom
Soltra:edge7_v1.1.1.3
Closed
Conversation
Since the idgen namespace settings are at the module-level, they could cause thread-safety issues, depending on the use. This patch moves the idgen gathering up to the to_xml() and out of nsparser, and optional by using the include_idgen=T/F parameter to to_xml. To implement a thread-safe to_xml() call, the caller should disable the include_idgen, and provide the needed namespaces using the ns_dict parameter.
Conflicts: stix/base.py stix/utils/nsparser.py
Conflicts: stix/base.py
… into edge7_v1.1.1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA