Skip to content

Handle CIQ Identities correctly#305

Merged
gtback merged 6 commits intomasterfrom
issue302
Oct 6, 2016
Merged

Handle CIQ Identities correctly#305
gtback merged 6 commits intomasterfrom
issue302

Conversation

@gtback
Copy link
Contributor

@gtback gtback commented Oct 4, 2016

Fix #302

@gtback
Copy link
Contributor Author

gtback commented Oct 4, 2016

@clenk , @rpiazza : Can one of you take a look at this and merge if it fixes the problems you were having, and the CI build passes?

@rpiazza
Copy link

rpiazza commented Oct 5, 2016

Ran a test - that idiom is still wrong.

@emmanvg seems to think it is some issue with getting the xsi:type set.

@clenk
Copy link
Contributor

clenk commented Oct 5, 2016

My problem may be unrelated - STIXPackage.from_xml() isn't reading in the Identity correctly and just creates a ta:Identity/ stub.

@clenk
Copy link
Contributor

clenk commented Oct 5, 2016

I believe my problem comes from IdentityType.buildchildren(), which does nothing if the NodeName_ == "Specification" which is true for a CIQIdentity. Should we do something like MalwareType.buildchildren(), which imports the proper extension module?

EDIT: Hmm, the CIQIdentity3_0InstanceType binding class has Specification, so maybe I'm barking up the wrong tree to suggest it be added to the default IdentityType.

@emmanvg
Copy link
Contributor

emmanvg commented Oct 6, 2016

Just pushed some changes. It should be working now. :)

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue I was seeing.

@gtback gtback merged commit 06d4b5a into master Oct 6, 2016
@gtback gtback deleted the issue302 branch October 6, 2016 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants