fix: update CRD path in controller tests after Helm migration#13
fix: update CRD path in controller tests after Helm migration#13
Conversation
Rename S3_ENDPOINT to GLOBAL_S3_ENDPOINT and add required env vars (GLOBAL_S3_FORCE_PATH_STYLE, TENANT_ID, REGION, POSTGREST_URL) for compatibility with newer storage-api. Bump default resource limits and update image to v1.32.0. Adjust e2e test Chrome flags and timeout.
The envtest CRD path still referenced the old kustomize location (config/crd/bases) which was removed in the Helm migration. Update to the new path (helm/supabase-operator/crds). Closes #12
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da632a0c3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| { | ||
| Name: "S3_ENDPOINT", | ||
| Name: "GLOBAL_S3_ENDPOINT", |
There was a problem hiding this comment.
This change removes the legacy S3_ENDPOINT env var and only sets GLOBAL_S3_ENDPOINT, but the shipped CRD/API defaults for spec.storageAPI.image are still supabase/storage-api:v1.25.7 (helm/supabase-operator/crds/supabase.strrl.dev_supabaseprojects.yaml:1473, api/v1alpha1/supabaseproject_types.go:180). In the common case where users set spec.storageAPI fields but omit image, admission defaulting can keep v1.25.7, and that version expects the legacy endpoint variable; the pod then starts with incompatible env configuration and storage cannot connect to S3.
Useful? React with 👍 / 👎.
1 participant
Summary
config/crd/basestohelm/supabase-operator/crdsininternal/controller/suite_test.goCloses #12
Test plan
make testpasses locally with all controller tests succeeding