fix: use original VCT identifiers in DCQL vct_values#307
Merged
masv3971 merged 1 commit intoSUNET:masv/infra/releasefrom Mar 13, 2026
Merged
Conversation
The OpenID4VP request object was populating vct_values with the type-metadata publication URL instead of the original VCT identifier from the VCTM (e.g. urn:eudi:pid:arf-1.5:1). Added VCTIdentifiersForScopes helper and switched the DCQL query builder to use it so vct_values matches the vct claim in issued credentials.
|
leifj
added a commit
to sirosfoundation/vc
that referenced
this pull request
Mar 13, 2026
buildDCQLQueryFromConfig was using GetVCTURL() (the publication URL) for vct_values in the DCQL query. This should use the original VCT identifier from the VCTM so it matches the vct claim in credentials. Same class of bug as fixed in apigw handlers_verifier.go (PR SUNET#307).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OpenID4VP request object was populating
vct_valuesin the DCQL query with the type-metadata publication URL (e.g.https://tecca.issuer.id.siros.org/type-metadata/pid_1_5) instead of the original VCT identifier from the VCTM (e.g.urn:eudi:pid:arf-1.5:1).This caused verification failures because the wallet's credential has the original VCT identifier in its
vctclaim, which doesn't match the URL the verifier was requesting.Related to #306 (same class of bug, different code path).
Fix
VCTIdentifiersForScopes()helper onCfgthat returns original VCT identifiers from the VCTM structshandlers_verifier.goto useVCTIdentifiersForScopes()instead ofVCTUrlsForScopes()Files changed
pkg/model/config.go— newVCTIdentifiersForScopesmethodinternal/apigw/apiv1/handlers_verifier.go— use new method forvct_values