Skip to content

1.5.1 also require single db role during upgrades#650

Merged
btat merged 2 commits intodevelopfrom
sa-to-ha
Dec 13, 2019
Merged

1.5.1 also require single db role during upgrades#650
btat merged 2 commits intodevelopfrom
sa-to-ha

Conversation

@btat
Copy link
Copy Markdown
Collaborator

@btat btat commented Dec 12, 2019

No description provided.

@btat btat added the 1.5.1 Content should be added to 1.5.1 branch label Dec 12, 2019
Copy link
Copy Markdown

@satadruroy satadruroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested...

Comment thread xml/cap_admin_upgrade.xml Outdated
<itemizedlist>
<listitem>
<para>
The <literal>mysql</literal> roles are in high availability mode by setting
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change in wording - "The mysql roles can be configured to run in high availability mode..."

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the suggested wording not really fit the context here since we're trying say something like

If your current setup is A, go to link X
If your current setup is B, go to link Y

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about it so feel free to disregard...just sounds like something's missing. Would "The mysql roles are running in high availability mode..." sound better?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use "are currently running in high availability mode"

Comment thread xml/cap_admin_upgrade.xml Outdated
<listitem>
<para>
The <literal>mysql</literal> roles are in high availability mode by
configuring custom sizing values, see
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update wording in bb88210

Comment thread xml/cap_admin_upgrade.xml Outdated
<para>
For the <literal>uaa</literal> deployment, scale the instance count of the
<literal>mysql</literal> role to 1 and remove the associated persistent
volume claim.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make it clear that the PVCs corresponding to the removed instances need to be deleted, not the remaining PVC, i.e., after scaling down to mysql-0, mysql-pvc-1 and mysql-pvc-2 should be deleted.

Copy link
Copy Markdown
Collaborator Author

@btat btat Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update wording for this and other similar occurrences in bb88210

Comment thread xml/cap_admin_upgrade.xml Outdated
from the <literal>uaa</literal> namespace. <emphasis>Do not</emphasis>
delete the persistent volume (PV).
</para>
<screen>&prompt.user;kubectl delete persistentvolumeclaim --namespace uaa mysql-data-mysql-1</screen>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes there were only 2 instances of mysql to begin with? I think config.HA setting defaults the mysql count to 3.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update wording for this and other similar occurrences in bb88210

Comment thread xml/cap_admin_upgrade.xml Outdated
<para>
For the <literal>scf</literal> deployment, scale the instance count of the
<literal>mysql</literal> role to 1 and remove the associated
persistent volume claim.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, i.e. clarify the orphaned PVCs need to be removed.

Comment thread xml/cap_admin_upgrade.xml Outdated
<step>
<para>
Delete the persistent volume claim (PVC) for <literal>mysql-1</literal>
from the <literal>scf</literal> namespace. <emphasis>Do not</emphasis>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above...

Comment thread xml/cap_admin_upgrade.xml Outdated
<para>
For the <literal>uaa</literal> deployment, scale the instance count of the
<literal>mysql</literal> role to 1 and remove the associated persistent
volume claim.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above...

Comment thread xml/cap_admin_upgrade.xml Outdated
<step>
<para>
Delete the persistent volume claim (PVC) for <literal>mysql-1</literal>
from the <literal>uaa</literal> namespace. <emphasis>Do not</emphasis>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case the customer would need to delete all the orphaned PVCs for the rest of the instances, not just the one corresponding to mysql-1...

Comment thread xml/cap_admin_upgrade.xml Outdated
<para>
For the <literal>scf</literal> deployment, scale the instance count of the
<literal>mysql</literal> role to 1 and remove the associated
persistent volume claim.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above...

Comment thread xml/cap_admin_upgrade.xml Outdated
<step>
<para>
Delete the persistent volume claim (PVC) for <literal>mysql-1</literal>
from the <literal>scf</literal> namespace. <emphasis>Do not</emphasis>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeat...

Copy link
Copy Markdown
Member

@gaktive gaktive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear to me.

@btat btat merged commit 366cd12 into develop Dec 13, 2019
@btat btat deleted the sa-to-ha branch December 13, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.5.1 Content should be added to 1.5.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants