Skip to content

Predefine output file for media#310

Merged
atanasdinov merged 3 commits intoSUSE:mainfrom
atanasdinov:fix-ext-999
Dec 12, 2025
Merged

Predefine output file for media#310
atanasdinov merged 3 commits intoSUSE:mainfrom
atanasdinov:fix-ext-999

Conversation

@atanasdinov
Copy link
Copy Markdown
Contributor

@atanasdinov atanasdinov commented Dec 12, 2025

  • Customising images now accepts the user provided --output value or the generated image-<timestamp>.<type> one
  • Validates that --mode option can only be embedded or split

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
@dirkmueller
Copy link
Copy Markdown
Member

@atanasdinov
Copy link
Copy Markdown
Contributor Author

This line references how the default output would look and it's correct.

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
@atanasdinov atanasdinov marked this pull request as ready for review December 12, 2025 08:53
@atanasdinov atanasdinov requested a review from a team as a code owner December 12, 2025 08:53
@dirkmueller
Copy link
Copy Markdown
Member

This line references how the default output would look and it's correct.

well, it seemed to me we supported both a directory and a full filename here before, that's why I was wondering.

@atanasdinov
Copy link
Copy Markdown
Contributor Author

Nope, I believe even if it had happened before, it must have been a side effect. The --output flag is always path to a file, never a directory. Also referenced in the description:

Usage: "Filepath for the output image",

@atanasdinov atanasdinov merged commit 56efb64 into SUSE:main Dec 12, 2025
4 checks passed
@dirkmueller
Copy link
Copy Markdown
Member

Usage: "Filepath for the output image",

okay, I read that as file/path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants